Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
mindsdb_sdk/chatbot.py
Outdated
| @@ -0,0 +1,174 @@ | |||
| from typing import List | |||
There was a problem hiding this comment.
It is the double of chatbots.py, isn't ?
mindsdb_sdk/chatbots.py
Outdated
| data=payload | ||
| ) | ||
|
|
||
| if inplace: |
There was a problem hiding this comment.
What could be the reason to update chatbot on server and not update local instance?
There was a problem hiding this comment.
I think there's no reason for it 😅😅
mindsdb_sdk/chatbots.py
Outdated
| Example usage: | ||
| >>> chatbot.delete() | ||
| """ | ||
| self.api.delete_chatbot(self.project.name, self.name) |
There was a problem hiding this comment.
There is chatbots.drop(name) method for this
There was a problem hiding this comment.
this can be used to delete chatbot through it's instance instead of name.
shoud i remove this?
There was a problem hiding this comment.
lets remove it, it doesn't match with others objects API
|
|
||
| def __repr__(self): | ||
| return f"{self.__class__.__name__}({self.project.name}.{self.name})" | ||
|
|
There was a problem hiding this comment.
Just an idea what methods could be useful:
- maybe add 'start'/'stop' methods?
Also a user would be interested in last error message for chatbot. is it accessible via rest API?
There was a problem hiding this comment.
for start stop methods we can change is_running.
but "last error message", i am unable to understand it clearly
mindsdb_sdk/chatbots.py
Outdated
| Example usage: | ||
| >>> chatbot.delete() | ||
| """ | ||
| self.api.delete_chatbot(self.project.name, self.name) |
There was a problem hiding this comment.
lets remove it, it doesn't match with others objects API
3 participants
fixes #165
py.sdk.mdb.mp4